From: Jasper St. Pierre <jstpierre@mecheye.net>
Date: Sun, 18 Nov 2012 15:49:31 +0000 (-0500)
Subject: overview: Fix stuck grabs when mashing the overlay-key
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~5261
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=14fb51e6d7079abe81cccdaabf8221ff3283ec4c;p=gnome-shell.git

overview: Fix stuck grabs when mashing the overlay-key

When pressing the overlay key three times, things went like this:

  * show(), push a modal
  * hide(), will pop a modal after hiding is done
  * show(), push a modal

Thus, when the showing is done, and then it activated the hiding,
it popped one modal, but not the other. This patch changes things
to be:

  * show(), push a modal
  * hide(), will pop a modal after hiding is done
  * hide(), no-op

That is, mashing the overlay-key when it's showing will always make
it hide, not mashing an odd number of times.

https://bugzilla.gnome.org/show_bug.cgi?id=688589
---

diff --git a/js/ui/overview.js b/js/ui/overview.js
index 9c9137885..da4dbae14 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -562,7 +562,7 @@ const Overview = new Lang.Class({
         if (this.isDummy)
             return;
 
-        if (this._shown)
+        if (this.visible)
             this.hide();
         else
             this.show();